Add Shanghai revision #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
approved these changes
May 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 95.70% 95.71% +0.01%
==========================================
Files 24 24
Lines 3954 3971 +17
==========================================
+ Hits 3784 3801 +17
Misses 170 170 |
chfast
approved these changes
Jun 28, 2021
axic
reviewed
Jun 28, 2021
test/unittests/instructions_test.cpp
Outdated
| const auto sn = evmc_get_instruction_names_table(EVMC_SHANGHAI); | ||
| const auto ln = evmc_get_instruction_names_table(EVMC_LONDON); | ||
|
|
||
| for (int op{OP_STOP}; op <= OP_SELFDESTRUCT; ++op) |
There was a problem hiding this comment.
Still think this should go by 0x00 .. 0xff and not the instruction names.
axic
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.